Merge bugzilla.py module with models.py
#183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsieber-mozilla
approved these changes
Aug 2, 2022
Contributor
bsieber-mozilla
left a comment
bsieber-mozilla
left a comment
There was a problem hiding this comment.
Minor resolvable comments, overall lgtm!
Contributor
Author
I was running into a circular import after making this change, and the only reason for that was an import for the purposes of type hinting. I found this blog post that lead me to add the changes that you called out in your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
bugzilla.pywas a collection of PydanticBaseModels, in this PR we move them intomodels.pyso that it is the one source of all models used in the app.